Consolidate `iter_raw_entries` and generic `iter_column`

sigp / lighthouse

Ethereum consensus client in Rust

https://lighthouse.sigmaprime.io/

Apache License 2.0

2.86k stars 716 forks source link

Consolidate `iter_raw_entries` and generic `iter_column` #4692

Open michaelsproul opened 11 months ago

michaelsproul commented 11 months ago

Description

In Deneb we're adding two new methods to the database:

iter_raw_entries and
iter_raw_keys

Similar changes are made in #4648 and tree-states, by generalising the existing column iterators to operate over keys of different sizes. I suspect we could consolidate and just keep the generic column iterators once they're available. Some further abstraction over the values to get raw values might be needed.

eserilev commented 5 months ago

I've consolidated iter_raw_entires and iter_raw_keys to their generic column iterator counterparts in https://github.com/sigp/lighthouse/pull/4718.