search

sigp / lighthouse

Ethereum consensus client in Rust
https://lighthouse.sigmaprime.io/
Apache License 2.0
2.9k stars 736 forks source link

Validator manager commands for standard key-manager APIs #4854

Open michaelsproul opened 11 months ago

michaelsproul commented 11 months ago

Description

The Lighthouse validator manager import command takes a Vec<ValidatorSpecification> as input, which makes it unsuitable for use with keystores from non-Lighthouse sources.

It would be great to have a command that can import standard keystore files, with options for passwords, etc. Basically an analogue of the old account-manager import command that works with the keymanager API.

For completeness it would also be good to have basic commands for the other key-manager APIs like list, delete, etc, which don't use any Lighthouse-specific extensions. This would allow interop with non-Lighthouse VCs, and provide a nicer front-end to the KM APIs that doesn't involve crafting JSON by hand.

Version

Lighthouse v4.5.0

Steps to resolve

Add new commands to lighthouse validator-manager which just use the standard APIs.

pahor167 commented 7 months ago

I created following https://github.com/sigp/lighthouse/pull/5347 - this is my first PR, please let me know if anything is missing