search

sigp / lighthouse

Ethereum consensus client in Rust
https://lighthouse.sigmaprime.io/
Apache License 2.0
2.9k stars 736 forks source link

Update clap, and potentially move to derive #5087

Open realbigsean opened 8 months ago

realbigsean commented 8 months ago

Description

I started on moving to clap derive a while ago, so there is work started that could be picked up, but it's pretty difficult to keep up to date. We'd get a little more compile time safety, but it is a lot of changes, so not totally sure it's worth it. Relevant PRs:

https://github.com/sigp/lighthouse/pull/3007 https://github.com/sigp/lighthouse/pull/2960

eserilev commented 7 months ago

I'd like to try to get this across the finish line. I'm wondering if we could do the clap upgrades in stages, i.e. separate prs for bootnode, beacon node, vc etc. That way we could avoid one huge PR

EDIT: After some further investigation it seems like at the very least the BN + bootnode need to be upgraded together. Will see if I can keep the VC to a separate PR.

realbigsean commented 7 months ago

I'd like to try to get this across the finish line. I'm wondering if we could do the clap upgrades in stages, i.e. separate prs for bootnode, beacon node, vc etc. That way we could avoid one huge PR

I think that's a good idea and from what I remember should be possible, haven't checked out your PR yet but will try to get to it soon (off for the next couple weeks though)