--disable-log-timestamp doesn't work in v5.2.1-9e12c21

matthewdarwin commented 3 months ago

Description

After upgrading from 5.1.x, get error when passing --disable-log-timestamp

 Usage: lighthouse beacon_node --network <network> --debug-level <LEVEL> --datadir <DIR> --disable-upnp --listen-address [<ADDRESS>...] --metrics --metrics-address <ADDRESS> --execution-endpoint <EXECUTION-ENDPOINT> --port <PORT> --execution-jwt <EXECUTION-JWT> --disable-log-timestamp <--http|--gui|--staking>

Version

v5.2.1-9e12c21

Present Behaviour

Lighthouse will not start with --disable-log-timestamp

Expected Behaviour

Lighthouse should start properly

Steps to resolve

Removed --disable-log-timestamp, starts ok

chong-he commented 3 months ago

Not sure if I miss anything, but I tested and it is working:

./lighthouse2 beacon_node --network mainnet --debug-level info --datadir data --disable-upnp --listen-address 0.0.0.0 --metrics --metrics-address 0.0.0.0 --execution-endpoint http://localhost:8551/ --port 9100 --execution-jwt /home/hi/.ethereum/geth/jwtsecret --disable-log-timestamp --http --gui --staking --checkpoint-sync-url https://mainnet.checkpoint.sigp.io

./lighthouse2 --version:

Lighthouse v5.2.1-9e12c21
BLS library: blst-portable
SHA256 hardware acceleration: false
Allocator: jemalloc
Profile: maxperf
Specs: mainnet (true), minimal (false), gnosis (true)

Logs:

 INFO Logging to file                         path: "data/beacon/logs/beacon.log"
 INFO Lighthouse started                      version: Lighthouse/v5.2.1-9e12c21
 INFO Configured for network                  name: mainnet
 INFO Data directory initialised              datadir: data
 WARN Running HTTP server on port 5052
 INFO Deposit contract                        address: 0x00000000219ab540356cbb839cbe05303d7705fa, deploy_block: 11184524
 WARN Legacy datadir location                 location: "/home/hi/data/beacon", msg: this occurs when using relative paths for a datadir location
 INFO Blob DB initialized                     oldest_blob_slot: Some(Slot(8626176)), path: "/home/hi/data/beacon/blobs_db", service: freezer_db
 INFO Starting checkpoint sync                remote_url: https://mainnet.checkpoint.sigp.io/, service: beacon
 INFO Loaded checkpoint block and state       block_root: 0xbf26c8f5bbdd0694abae70d8f2578215020da2ec66013a028a742fbfb355d4b1, state_slot: 9482720, block_slot: 9482720, service: beacon
 INFO Loaded deposit tree snapshot            deposits loaded: 1576786, service: beacon
 INFO Block production enabled                method: json rpc via http, endpoint: Auth { endpoint: "http://localhost:8551/", jwt_path: "/home/hi/.ethereum/geth/jwtsecret", jwt_id: None, jwt_version: None }
 WARN Error connecting to eth1 node endpoint  endpoint: http://localhost:8551/, auth=true, service: beacon
 ERRO Error updating deposit contract cache   error: Invalid endpoint state: RequestFailed("eth_chainId call failed HttpClient(url: http://localhost:8551/, kind: request, detail: error trying to connect: tcp connect error: Connection refused (os error 111))"), retry_millis: 60000, service: beacon
 WARN Error connecting to eth1 node endpoint  endpoint: http://localhost:8551/, auth=true, service: beacon
 ERRO Error updating deposit contract cache   error: Invalid endpoint state: RequestFailed("eth_chainId call failed HttpClient(url: http://localhost:8551/, kind: request, detail: error trying to connect: tcp connect error: Connection refused (os error 111))"), retry_millis: 60000, service: beacon
 INFO Beacon chain initialized                head_slot: 9482720, head_block: 0xbf26…d4b1, head_state: 0xc46d…acb2, service: beacon
 INFO Timer service started                   service: node_timer
 INFO Execution payloads are pruned           service: freezer_db
 INFO ENR Initialised                         quic6: None, quic4: Some(9101), udp6: None, tcp6: None, tcp4: Some(9100), udp4: None, ip4: None, id: 0xef83..f190, seq: 1, enr: enr:-LW4QKwSKeY7R-1jl5C1W4EC1ASjkL9x_ZG9eBmtUZuU0I7jCaWwOp1jQBQzbJbbnEMmePFjsWBEs1XUqhGyZ5zRM94Bh2F0dG5ldHOIAAAAAAAAAACEZXRoMpBqlaGpBAAAAP__________gmlkgnY0hHF1aWOCI42Jc2VjcDI1NmsxoQPmWbnpAkso43Z7Jd4YE-hPflgzi9cjvv3X9KAT0vL3_YhzeW5jbmV0cwCDdGNwgiOM, service: libp2p
 INFO Libp2p Starting                         bandwidth_config: 3-Average, peer_id: 16Uiu2HAmUABUXbgKyy9WHvy41HZi7osUNUg8RpNdP4gaSzhTUDSC, service: libp2p
 INFO Listening established                   address: /ip4/0.0.0.0/tcp/9100/p2p/16Uiu2HAmUABUXbgKyy9WHvy41HZi7osUNUg8RpNdP4gaSzhTUDSC, service: libp2p
 INFO Listening established                   address: /ip4/0.0.0.0/udp/9101/quic-v1/p2p/16Uiu2HAmUABUXbgKyy9WHvy41HZi7osUNUg8RpNdP4gaSzhTUDSC, service: libp2p
 INFO Deterministic long lived subnets enabled, subscription_duration_in_epochs: 256, subnets_per_node: 2, service: attestation_service
 INFO Subscribing to long-lived subnets       subnets: [SubnetId(9), SubnetId(10)], service: attestation_service
 INFO HTTP API started                        listen_address: 127.0.0.1:5052
 INFO Metrics HTTP server started             listen_address: 0.0.0.0:5054

matthewdarwin commented 3 months ago

We had --disable-log-timestamp=true before. Now we need --disable-log-timestamp without the =true.

sigp / lighthouse