sigp / lighthouse

Ethereum consensus client in Rust
https://lighthouse.sigmaprime.io/
Apache License 2.0
2.88k stars 724 forks source link

DHT persistence tests fail with a running node. #871

Closed paulhauner closed 4 years ago

paulhauner commented 4 years ago

Description

I'm getting the following error when running cargo test --all --release:

---- service::tests::test_dht_persistence stdout ----
thread 'service::tests::test_dht_persistence' panicked at 'called `Result::unwrap()` on an `Err` value: Error(Libp2p(Msg("Discv5 service failed. Error: Os { code: 98, kind: AddrInUse, message: \"Address already in use\" }")), State { next_error: None, backtrace: InternalBacktrace { backtrace: None } })', src/libcore/result.rs:1188:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

I also have a beacon node running in the background. I assume that it's using a port that the tests expect to have open? It would be nice if we could run a node and also pass tests.

paulhauner commented 4 years ago

@pawanjay176 I think you might be familiar with this test?

AgeManning commented 4 years ago

Yeah, @pawanjay176 looks like will have to use non-standard config. Need to change this guy: https://github.com/sigp/lighthouse/blob/master/beacon_node/network/src/service/tests.rs#L67

pawanjay176 commented 4 years ago

Sorry, saw this now. Will push a fix soon :)

paulhauner commented 4 years ago

Resolved by #874