sigrennesmetropole / geor_urbanisme_mapstore

GNU General Public License v3.0
2 stars 5 forks source link

No NRU or ADS information in case of layer selection in the TOC #33

Closed catmorales closed 1 year ago

catmorales commented 2 years ago

Platform : https://portail-test.sig.rennesmetropole.fr Context : https://portail-test.sig.rennesmetropole.fr/mapstore/#/context/master-urba-foncier In this application context identify tool is disabbled because it's a dedicated "urbanisme and foncier" context.

Same behavior with a layer group selected.

We believe that when the NRU and ADS functions are activated, the click should provide their information sheet regardless of the layers selected in the TOC. Closing the Urbanism plugin, restores the standard operation.

This is the behaviour observed in Cadastrapp.

MaelREBOUX commented 2 years ago

Linked to https://github.com/georchestra/mapstore2-cadastrapp/issues/134

offtherailz commented 2 years ago

@tdipisa I add these notes for developers, in order to get a starting point and to keep a report my investigation: Actually urbanisme plugin uses Identify plugins functionalities (call for identify action, wait for the epics of Identify plugin to respond).

To avoid this problem, it should call directly the GFI api and process the response.

MaelREBOUX commented 2 years ago

So. Below what we meet actually :

ms2_urbanisme_toc_layer_selection

The "clic on the map to show NRU or ADS info" tool must be active as long as the urbanisme tool is loaded and must not be disturbed by the sélection of something in the TOC. This way we will have a similar behaviour as cadastrapp.

Is it more clear ?

tdipisa commented 2 years ago

@MaelREBOUX it was clear for us even before: the @offtherailz comment above is just a note for developers. Thank you anyway for clarifying further in the issue.

MaelREBOUX commented 2 years ago

@tdipisa I deleted the messages that were related to our behaviour on our test portal and is out of the scope of this bug report. To not pollute the issue.

catmorales commented 2 years ago

corrected by #42

MaelREBOUX commented 1 year ago

Seems have corrected this bug.