sigrennesmetropole / geor_urbanisme_mapstore

GNU General Public License v3.0

2 stars 5 forks source link

#42 Updated test; Test changes to resolve map toolbar padding on map info toggle #47

Closed alexander-fedorenko closed 2 years ago

alexander-fedorenko commented 2 years ago

Description

Amended test; Added test changes that should resolve issue with map toolbar padding.

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Issue

What is the current behavior?

42

What is the new behavior? As per description

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

[ ] Yes, and I documented them in migration notes
[x] No

Other useful information

offtherailz commented 2 years ago

I tested it again and it works. For both my build and github action I suppose I did some error during the build ... Github action actually dobule zip the artifact. going to correct and then merge this PR. Thank you @alexander-fedorenko