Extension had problems when used with custom projections in production mode.
This was indirectly caused by recent changes to make it independent from identify plugin.
Functionality that build requests and defines logic of how and where from data should be requested was moved to the extension, which made impossible to use hooks defined by the map plugin (they become out of scope, defined in main app bundle).
This PR provides a slight change to overcome this limitation. It adds a code that registers hook to get current resolution from the store (where resolutions are always up-to-date).
Please check if the PR fulfills these requirements
[] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (check one with "x", remove the others)
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:
Issue
What is the current behavior?
42
What is the new behavior?
As per description
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
[ ] Yes, and I documented them in migration notes
[x] No
Other useful information
New hook instance is being used ONLY by this extension. It is baked into build and used only to get proper resolution when bounding box for request is calculated. Any other plugin from main bundle will use hooks defined in main app.
Description
Extension had problems when used with custom projections in production mode. This was indirectly caused by recent changes to make it independent from identify plugin. Functionality that build requests and defines logic of how and where from data should be requested was moved to the extension, which made impossible to use hooks defined by the map plugin (they become out of scope, defined in main app bundle). This PR provides a slight change to overcome this limitation. It adds a code that registers hook to get current resolution from the store (where resolutions are always up-to-date).
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
42
What is the new behavior? As per description
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
New hook instance is being used ONLY by this extension. It is baked into build and used only to get proper resolution when bounding box for request is calculated. Any other plugin from main bundle will use hooks defined in main app.