sigrennesmetropole / geor_urbanisme_mapstore

GNU General Public License v3.0
2 stars 5 forks source link

Livraison 2.1.0 #64

Closed FNI18300 closed 1 year ago

FNI18300 commented 1 year ago

This pull request embeds 2 main proposals :

The jasper template has been modified to provide generation of urban information grouped by theme. The "urbanismeRenseignGroupe" parameter is used to configure the use of this grouping (default value is false).

If the "urbanismeRenseignGroupe" parameter is set to true, the new API from sigrennesmetropole/addon_urbanisme is used and the document of urban information is generated grouped by theme. If the "urbanismeRenseignGroupe" parameter is set to false, the legacy API from sigrennesmetropole/addon_urbanisme is used and the document of urban information as before.

jusabatier commented 1 year ago

Any comment for explain what implements the PR ?

For what I understand, it add a new implementation for constraint's groups linked to numbers. What are those numbers that are hardcoded corresponding to ?

Maybe you can also update the README to add the new 'urbanismeRenseignGroupe' config option and explain it.

It could be useful to explain the expected response when set it to true (JSON, XML, ... ? / Expected format, attributes, ... ?)

catmorales commented 1 year ago

@FNI18300 , as @jusabatier said, I'd like you to add a release note explaining the aim of this update. Thank you very much. It's necessary for all.

Do we need to add ""urbanismeRenseignGroupe": false" into the plugin parameters , I didn't do it and for what ? It should be better to understand if this issue is linked :https://github.com/sigrennesmetropole/geor_urbanisme_mapstore/issues/65