search

sigsep / open-unmix-pytorch

Open-Unmix - Music Source Separation for PyTorch
https://sigsep.github.io/open-unmix/
MIT License
1.24k stars 181 forks source link

Hub loader doesn't use wiener_win_len argument value #106

Closed papahabla closed 5 months ago

papahabla commented 3 years ago

I'm not sure if this is intentional or not but the wiener_win_len argument is not used by the hub_loader in the following code.

    # otherwise we load the separator from torchhub
    else:
        hub_loader = getattr(openunmix, model_str_or_path)
        separator = hub_loader(
            targets=targets,
            device=device,
            pretrained=True,
            niter=niter,
            residual=residual,
            filterbank=filterbank,
        )

To Reproduce

Call the command line with default and different --wiener-win-len value such as 600 and the outputs will be identical.

faroit commented 3 years ago

@papahabla good catch. Are you able to provide a PR to fix this?