search

sigsep / open-unmix-pytorch

Open-Unmix - Music Source Separation for PyTorch
https://sigsep.github.io/open-unmix/
MIT License
1.24k stars 181 forks source link

Missing import of predict when extracting from youtube #108

Open aframires opened 2 years ago

aframires commented 2 years ago

🐛 Bug

When running the Colab just for extracting the stems from the youtube video, we get NameError: name 'predict' is not defined. This might have been overlooked as the import of predict happens on the Separate MUSDB18 tracks section. I think there should not be any need to run that section if the user just desires to extract the stems from an youtube video.

To Reproduce

Steps to reproduce the behaviour:

  1. Run Installation and Imports
  2. Do not run Separate MUSDB18 tracks
  3. Run Separate Youtube Video

Expected behaviour

The loading in from openunmix import predict should happen either in Installation and Imports or in both Separate MUSDB18 tracks and Separate Youtube Video

Environment

Please add some information about your environment

faroit commented 2 years ago

@aframires thanks, probably I've overlooked something. I can fix this soon