sigsep / open-unmix-pytorch

Open-Unmix - Music Source Separation for PyTorch
https://sigsep.github.io/open-unmix/
MIT License
1.27k stars 191 forks source link

Convert training model to pytorch-lightning #47

Closed faroit closed 4 years ago

faroit commented 4 years ago

lightning has matured enough to be used to refactor open-unmix.

faroit commented 4 years ago

lightning would significantly clean up the training code but when using learning rate scheduling and distributed training code from lightning, users won't be able to reproduce the current pre-trained models.

Since results are reported in publications, we want to reduce confusion, and therefore do not currently plan to retrain the model without major core changes. Hence, I propose to skip this feature until we have a core change in the model