search

sigsep / sigsep-mus-db

Python parser and tools for MUSDB18 Music Separation Dataset
https://sigsep.github.io/sigsep-mus-db/
MIT License
159 stars 33 forks source link

Save MultiTrack in mp4 #72

Open giorgiacantisani opened 3 years ago

giorgiacantisani commented 3 years ago

Hi!

I would like to modify the audio files in MUSDB and then save them again in the .mp4 format. How can I do this? I noticed that this feature is not currently implemented (see save_estimates function in musdb).

So far, I tried with stempeg.write_stems function (https://github.com/faroit/stempeg) but I don't understand how to include the metadata.

Thank you very much

faroit commented 3 years ago

Hi @giorgiacantisani I am actually working on an reimplementation of the writing function. For now you can just follow this PR

https://github.com/faroit/stempeg/pull/28

If you can't wait, have a look at: https://github.com/sigsep/sigsep-mus-io/blob/master/scripts/encode.sh

How can I do this? I noticed that this feature is not currently implemented (see save_estimates function in musdb).

Once finished, would you say it makes sense to offer stems writing from musdb as well?

giorgiacantisani commented 3 years ago

Thank you very much for your suggestions!

I think it would definitely make sense. For example, in my case, I would like to modify the dataset and save again each MultiTrack object. In other cases, you may want to add some annotations or other metadata.

faroit commented 3 years ago

@giorgiacantisani stempeg 0.2.1 was just released and fully supports writing stems. how would you suggest to add this feature to musdb?

giorgiacantisani commented 3 years ago

Hi! I suggest adding a save method to the class Multitrack so that you can load the tracks, modify and save them easily using the same object. What do you think?