codecov[bot]
commented
3 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 40.42%. Comparing base (
2ef6022) to head (4dca07c). Report is 67 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #3643 +/- ## ========================================== + Coverage 40.10% 40.42% +0.32% ========================================== Files 155 155 Lines 10044 10088 +44 ========================================== + Hits 4028 4078 +50 + Misses 5530 5517 -13 - Partials 486 493 +7 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Mukuls77
cpanato
hectorj2f
This PR Closes #3642 The issue fixed is related to Memory leak happening in File: https://github.com/sigstore/cosign/blob/6206f5af392ccefcc6a6cbb167bbccc833b46ed4/pkg/oci/internal/signature/layer.go#L60 Function: func (s *sigLayer) Payload() ([]byte, error)
Summary
The cause of the problem as identified is missing Defer call in function func (s sigLayer) Payload() ([]byte, error) { // Compressed is a misnomer here, we just want the raw bytes from the registry. r, err := s.Layer.Compressed() if err != nil { return nil, err } payload, err := io.ReadAll(r) if err != nil { return nil, err } return payload, nil } so the code changes done is to introduce Defer clause before returning from function to close the file stream. func (s sigLayer) Payload() ([]byte, error) { // Compressed is a misnomer here, we just want the raw bytes from the registry. r, err := s.Layer.Compressed() if err != nil { return nil, err } payload, err := io.ReadAll(r) if err != nil { return nil, err } defer r.Close() return payload, nil }
Release Note
Bug fix for Issue #3642
Documentation
No change in Documentation