search

sigstore / cosign

Code signing and transparency for containers and binaries
Apache License 2.0
4.41k stars 542 forks source link

Remove KMS E2E test script #3702

Closed cmurphy closed 4 months ago

cmurphy commented 4 months ago

Should have been removed as part of fa17fab.

Summary

Release Note

Documentation

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.60%. Comparing base (2ef6022) to head (ae111c6). Report is 109 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3702 +/- ## ========================================== + Coverage 40.10% 40.60% +0.49% ========================================== Files 155 157 +2 Lines 10044 10157 +113 ========================================== + Hits 4028 4124 +96 - Misses 5530 5535 +5 - Partials 486 498 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

haydentherapper commented 4 months ago

Can you remove https://github.com/sigstore/cosign/blob/121115774e8c662648165f2924e7354292365ae8/.github/workflows/kind-e2e-insecure-registry.yaml#L32 too to get the tests passing? Looks like 1.24.x was dropped in https://github.com/chainguard-dev/actions/pull/430/

cmurphy commented 4 months ago

@haydentherapper https://github.com/sigstore/cosign/pull/3701 already takes care of that

haydentherapper commented 4 months ago

SG, I'll get that merged now then.