search

sigstore / cosign

Code signing and transparency for containers and binaries
Apache License 2.0
4.4k stars 541 forks source link

Remove sign_blob_test.sh test #3707

Closed cmurphy closed 4 months ago

cmurphy commented 4 months ago

The bug that this test was meant to address[1] applies to a feature that was removed from cosign[2]. The updates made to the script to allow for the breaking changes actually make the test invalid, because while it was once verifying the original artifact signature, the final verification step is now actually verifying against the uploaded rekor entry, so the original signature is inconsequential.

[1] https://github.com/sigstore/cosign/pull/1673 [2] https://github.com/sigstore/cosign/pull/2425

Summary

Release Note

Documentation

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.60%. Comparing base (2ef6022) to head (363a64d). Report is 110 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3707 +/- ## ========================================== + Coverage 40.10% 40.60% +0.49% ========================================== Files 155 157 +2 Lines 10044 10157 +113 ========================================== + Hits 4028 4124 +96 - Misses 5530 5535 +5 - Partials 486 498 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

haydentherapper commented 4 months ago

Thanks for cleaning this up!