search

sigstore / cosign

Code signing and transparency for containers and binaries
Apache License 2.0
4.24k stars 507 forks source link

fix golangci-lint issues in the test/ directory #3760

Closed dmitris closed 3 days ago

dmitris commented 6 days ago

Description

Current golangci-lint issues from golangci-lint run --build-tags e2e ./test: https://gist.github.com/dmitris/5b43918c553946a3b77247622d63e277 need to fix at least some of them - those that are "reasonable" to fix (ex. I would pass on the errcheck issues - "Error return value of [...] is not checked".

cpanato commented 6 days ago

thanks, i will work on those, maybe we can also enable this to run on ci

dmitris commented 6 days ago

for CI, it would be good to add a .golangci.yml file and disable there the "noisy" linters (such as errcheck) which we don't want to enforce.

cpanato commented 6 days ago

i think we want the errcheck even if that is kind noisy

dmitris commented 6 days ago

i think we want the errcheck even if that is kind noisy

but then we wouldn't be able to break the builds on new golangci-lint issues, right? Unless we either fix or //nolint:errcheck the "preexisting conditions"