Open dmitris opened 6 days ago
Attention: Patch coverage is 66.66667%
with 26 lines
in your changes missing coverage. Please review.
Project coverage is 37.05%. Comparing base (
2ef6022
) to head (4c31442
). Report is 146 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary
Copy the handling of non-Fulcio keys from the
verify
to all the other verify commands (verify-attestation
,verify-blob
,verify-blob-attestations
).Currently the large code snippets for the
if keylessVerification(c.KeyRef, c.Sk) {
code are copied verbatim into several files (yikes!) - the intention is to factor this out into a helper function.Fix #3759.
Release Note
--ca-roots
/--ca-intermediates
parameters to theverify-attestation
,verify-blob
, andverify-blob-attestations
commands (in addition toverify
)Documentation
TODO - create a corresponding https://github.com/sigstore/docs PR