search

sigstore / cosign

Code signing and transparency for containers and binaries
Apache License 2.0
4.24k stars 507 forks source link

Update README.md developer setup to use go 1.22+ #3764

Closed bminahan73 closed 5 days ago

bminahan73 commented 5 days ago

Summary

go 1.19+ is called out in the README for developer setup. However, the use of toolchain keyword requires go 1.22+ and build fails with go 1.19.

Fixes: https://github.com/sigstore/cosign/issues/3763

Release Note

NONE

Documentation

No

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.71%. Comparing base (2ef6022) to head (8133f67). Report is 143 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3764 +/- ## ========================================== - Coverage 40.10% 36.71% -3.39% ========================================== Files 155 200 +45 Lines 10044 12283 +2239 ========================================== + Hits 4028 4510 +482 - Misses 5530 7223 +1693 - Partials 486 550 +64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.