search

sigstore / docs

Sigstore documentation
https://sigstore.dev
MIT License
70 stars 79 forks source link

Reposition toggle-button for Dark Mode in Docs #96

Closed Neilblaze closed 1 year ago

Neilblaze commented 1 year ago

Description

Most users nowadays prefer surfing docs with Dark-Mode enabled. But, in the current design, the user has to first scroll down to the bottom & then can access the toggle button to switch between themes, which I believe is a bad UX.

image

Solution

I propose a solution where we can shift the button to the sticky navbar which will remain fixed even if we scroll down, so that the user can switch between themes anytime they want. Plus, we can also shift the "Built with Nuxt" promo to the sidebar to make to reduce unnecessary space wastage on the viewport.

image

Final look 👇🏼

image

P.S. : If this issue is validated & approved, I'd love to contribute. Additionally, I do have a similar design in mind, following the same approach for responsive mode (i.e. mobile view).

Neilblaze commented 1 year ago

@ltagliaferri thoughts on this?

ltagliaferri commented 1 year ago

Hi @Neilblaze, the docs site is automatically set up to run dark or light mode based on system preferences. FWIW, we are thinking about replatforming the site in the near to mid-term future. I don't think this is an urgent need as docs are the more important concern, but if you feel strongly about it you can certainly open a PR.

Neilblaze commented 1 year ago

Closed as of now, refer to this!