search

sigstore / fulcio

Sigstore OIDC PKI
Apache License 2.0
646 stars 137 forks source link

chainguard issuer: use the same proof of possession cosign expects #1725

Closed priyawadhwa closed 2 months ago

priyawadhwa commented 2 months ago

this should allow the chainguard issuer to work when the email verified claim is set

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.61%. Comparing base (cf238ac) to head (552c5c1). Report is 136 commits behind head on main.

Files Patch % Lines
pkg/identity/chainguard/principal.go 50.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1725 +/- ## ========================================== - Coverage 57.93% 49.61% -8.32% ========================================== Files 50 71 +21 Lines 3119 4184 +1065 ========================================== + Hits 1807 2076 +269 - Misses 1154 1879 +725 - Partials 158 229 +71 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

haydentherapper commented 2 months ago

Closing in favor of the other