sigstore / fulcio

Sigstore OIDC PKI
Apache License 2.0
651 stars 137 forks source link

Designing list of requirements for new IDPs for public good deployment #397

Closed haydentherapper closed 4 months ago

haydentherapper commented 2 years ago

Description

In today's community meeting, we discussed two ways of supporting new IDPs:

We need to determine what are the requirements for a new IDP before inclusion.

Some initial thoughts:

What else would we like to see in in IDPs?

trevrosen commented 2 years ago

On a related note, I'm curious how the Sigstore team is planning to expand the list of the cert's SAN OIDs.

I'm interested in use cases involving multiple integrated build systems which also function as an IdP (like GitHub Actions does). Will the OID list expand to cover other systems directly or are there plans to abstract build-related claims?

evankanderson commented 1 year ago

Out of curiousity:

An OIDC provider must challenge the email address

What's the requirement for this?

Also, I'm wondering about:

Minimum set of supported claims (issuer, subject, audience, issued at, expiration). I propose that we don't enforce that all tokens have precise claim name (iss, sub, aud, for some examples), but that these values are represented in some claim on the token. For example, the subject could be in sub or email or maybe some other claim.

I'm assuming that for a given IDP, there is a specific claim which can be used as a long-term durable identity which will not be reused (per "we should require that IDPs prevent identity subject reuse"). So a config might look like:

GitHub:
  identity_claim: sub
Google:
  identity_claim: email  # hypothetical, probably not really
Microsoft:
  identity_claim: iss + email  # Do we need to support hybrid keys?
SPIFFE:
  identity_claim: iss + sub  # Might be a good example of why to support hybrid keys
haydentherapper commented 1 year ago

What's the requirement for this?

Proving ownership of an underlying identity, though I don't think it's a hard requirement. We can never know for certain that hayden@gmail provided by Google is the same as hayden@gmail provided by GitHub, but having this requirement would help.

haydentherapper commented 11 months ago

Fixed as of https://github.com/sigstore/fulcio/pull/1447. Please file any issues or propose changes if you have any concerns with the proposed policy.

FYI TSC, since there was interest in this list - @lukehinds @trevrosen @priyawadhwa @bobcallaway @SantiagoTorres

nealmcb commented 4 months ago

I.e. New IDP Requirements: https://github.com/pwelch/fulcio/blob/main/docs/new-idp-requirements.md

Thanks!

haydentherapper commented 4 months ago

This was merged in - https://github.com/sigstore/fulcio/blob/main/docs/new-idp-requirements.md