search

sigstore / policy-controller

Sigstore Policy Controller - an admission controller that can be used to enforce policy on a Kubernetes cluster based on verifiable supply-chain metadata from cosign
Other
123 stars 54 forks source link

Update supported k8s versions #1430

Closed codysoyland closed 5 months ago

codysoyland commented 5 months ago

chainguard-dev/actions/setup-kind no longer supports v1.23 and v1.24, so I'm removing them and adding the new versions.

Signed-off-by: Cody Soyland codysoyland@github.com

Summary

Release Note

Documentation

hectorj2f commented 5 months ago

You might want to upgrade scaffolding version and probably knative accordingly in the .github actions, e.g. SCAFFOLDING_RELEASE_VERSION.

hectorj2f commented 5 months ago

@codysoyland there is a draft PR from @cpanato bumping the version here: https://github.com/sigstore/policy-controller/pull/1063. Perhaps you can cherry pick his changes and hand hold that PR towards the finish line.

cpanato commented 5 months ago

i was dong that in my local :) but @codysoyland as you have this pr in place lets go with this one, let me know if you need any help

codysoyland commented 5 months ago

Gotcha, I didn't realize @cpanato was already working on that! I just bumped scaffolding so hopefully that helps!

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.19%. Comparing base (50ef092) to head (cc6de31). Report is 63 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1430 +/- ## =========================================== - Coverage 52.92% 42.19% -10.74% =========================================== Files 44 119 +75 Lines 3979 7124 +3145 =========================================== + Hits 2106 3006 +900 - Misses 1651 3766 +2115 - Partials 222 352 +130 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codysoyland commented 5 months ago

@cpanato @hectorj2f I think this is ready to go, but the required checks need to be updated in the settings because I have removed some older supported versions (per Carlos's last comment). I don't have access to that.

Also, I updated the supported versions table in the README, but it seems it hasn't been updated in several releases, so I'm not sure where the compatibility with older versions may have been broken. Please have a look if you can. Thanks!

cpanato commented 5 months ago

@cpanato @hectorj2f I think this is ready to go, but the required checks need to be updated in the settings because I have removed some older supported versions (per Carlos's last comment). I don't have access to that.

Also, I updated the supported versions table in the README, but it seems it hasn't been updated in several releases, so I'm not sure where the compatibility with older versions may have been broken. Please have a look if you can. Thanks!

cool

thank you! i will update the checks

cpanato commented 5 months ago

we need to merge this https://github.com/sigstore/community/pull/446 then it will update the checks and then we can merge this pr :)

thanks for all your work here @codysoyland