Open woodruffw opened 6 months ago
In practice, the PublicKey message is used in settings that require direct access to the raw_bytes, with the assumption that it isn't missing.
PublicKey
raw_bytes
https://github.com/sigstore/protobuf-specs/blob/2c9be05fb6720b5e07b5c96e99524abed9e0d14b/protos/sigstore_common.proto#L147-L155
We should be able to drop the optional qualifier here without causing any real breakage -- proto3 is still implicitly optional everywhere, so dropping optional will just refine the type hints.
optional
In practice, the
PublicKey
message is used in settings that require direct access to theraw_bytes
, with the assumption that it isn't missing.https://github.com/sigstore/protobuf-specs/blob/2c9be05fb6720b5e07b5c96e99524abed9e0d14b/protos/sigstore_common.proto#L147-L155
We should be able to drop the
optional
qualifier here without causing any real breakage -- proto3 is still implicitly optional everywhere, so droppingoptional
will just refine the type hints.