Use an alternative form to mark oneof fields as required

sigstore / protobuf-specs

Protocol Buffer specifications

Apache License 2.0

23 stars 29 forks source link

Use an alternative form to mark oneof fields as required #337

Open kommendorkapten opened 6 months ago

kommendorkapten commented 6 months ago

Summary

Use an alternative and updated method to mark oneof fields as REQUIRED.

Closes: https://github.com/sigstore/protobuf-specs/issues/336

Release Note

Updated how oneof fields are marked as REQUIRED in the protobuf

Documentation

N/A

haydentherapper commented 6 months ago

Dismissing my review, seems like this isn't WAI according to https://github.com/sigstore/sigstore-go/issues/63#issuecomment-2135585754

kommendorkapten commented 6 months ago

@haydentherapper yes, I did see in the other PR that this was fully WAI, I haven't had time to dig into this. My fear is that relying on annotations for verifying field behaviour may differ between clients :(