sigstore / rekor

Software Supply Chain Transparency Log
https://sigstore.dev
Apache License 2.0
904 stars 164 forks source link

hashedrekord: fix schema $id #2092

Closed woodruffw closed 7 months ago

woodruffw commented 7 months ago

This is a breakout from #2091: regardless of the body type change, the $id for the hashedrekord schema was incorrect (and was duplicated against the rekord schema, causing misgenerations in the Rust bindings).

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.95%. Comparing base (488eb97) to head (0f53bcc). Report is 89 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2092 +/- ## =========================================== - Coverage 66.46% 48.95% -17.51% =========================================== Files 92 80 -12 Lines 9258 6639 -2619 =========================================== - Hits 6153 3250 -2903 - Misses 2359 2985 +626 + Partials 746 404 -342 ``` | [Flag](https://app.codecov.io/gh/sigstore/rekor/pull/2092/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sigstore) | Coverage Δ | | |---|---|---| | [e2etests](https://app.codecov.io/gh/sigstore/rekor/pull/2092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sigstore) | `?` | | | [unittests](https://app.codecov.io/gh/sigstore/rekor/pull/2092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sigstore) | `48.95% <ø> (+1.26%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sigstore#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.