sigstore / rekor

Software Supply Chain Transparency Log
https://sigstore.dev
Apache License 2.0
857 stars 160 forks source link

Replace docker-compose with docker compose #2153

Closed cmurphy closed 2 weeks ago

cmurphy commented 3 weeks ago

Fixes CI error "ERROR: for rekor_rekor-server_1 'ContainerConfig'".

See https://forums.docker.com/t/docker-compose-up-fails-after-yesterday-update-possible-regression-in-2-25-0-1/140430/9

Summary

Release Note

Documentation

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.28%. Comparing base (488eb97) to head (299cae3). Report is 137 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2153 +/- ## =========================================== - Coverage 66.46% 50.28% -16.18% =========================================== Files 92 92 Lines 9258 7308 -1950 =========================================== - Hits 6153 3675 -2478 - Misses 2359 2760 +401 - Partials 746 873 +127 ``` | [Flag](https://app.codecov.io/gh/sigstore/rekor/pull/2153/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sigstore) | Coverage Δ | | |---|---|---| | [e2etests](https://app.codecov.io/gh/sigstore/rekor/pull/2153/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sigstore) | `50.28% <ø> (+2.72%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/sigstore/rekor/pull/2153/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sigstore) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sigstore#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bobcallaway commented 3 weeks ago

I used a conditional for environments who haven't updated to the latest version of docker in https://github.com/sigstore/rekor/blob/332c7ca6dc25721035444e4717908ca15142d58e/e2e-test.sh#L20 - you might want to do something similar here

cmurphy commented 3 weeks ago

@bobcallaway done