sigstore / root-signing

TUF repository for Sigstore trust root
Apache License 2.0
80 stars 77 forks source link

Update exit code for expected early exit #1180

Closed lkatalin closed 3 months ago

lkatalin commented 3 months ago

Fixes #1178

The root cause of the bug was the GHA ignores an exit 0 as an early exit. This PR changes the exit code to 2 in the early exit case, and adds output that can be checked in the if-failed job to skip creating an issue if the "failure" is just an early exit.

Update: This PR splits the sync step into two:

lkatalin commented 3 months ago

Updates made, thanks for the suggestions. I did some testing on the syntax the step uses to succeed/fail and this seemed to work.