search

sigstore / scaffolding

Stuff to make standing up sigstore (esp. for testing) easier for e2e/integration testing.
Apache License 2.0
57 stars 56 forks source link

metallb config issue using setup_kind #1145

Closed jkhelil closed 2 months ago

jkhelil commented 2 months ago

Description for tags prior to 0.6.17 (version supporting k8s prior to 1.26), When selecting the network for metallb config on setup_kind, this docker command returns the ipv6 subnet, and it is not safe https://github.com/sigstore/scaffolding/blob/v0.6.17/hack/setup-kind.sh#L243 network=$(docker network inspect kind -f "{{(index .IPAM.Config 0).Subnet}}" | cut -d '.' -f1,2)

here is the issue we are facing 

rror from server (parsing address pool config: invalid CIDR "fc00:f853:ccd:e793::/64.255.1-fc00:f853:ccd:e793::/64.255.250" in pool "config": invalid IP range "fc00:f853:ccd:e793::/64.255.1-fc00:f853:ccd:e793::/64.255.250": invalid start IP "fc00:f853:ccd:e793::/64.255.1"): error when creating "./metallb-crds.yaml": admission webhook "ipaddresspoolvalidationwebhook.metallb.io" denied the request: parsing address pool config: invalid CIDR "fc00:f853:ccd:e793::/64.255.1-fc00:f853:ccd:e793::/64.255.250" in pool "config": invalid IP range "fc00:f853:ccd:e793::/64.255.1-fc00:f853:ccd:e793::/64.255.250": invalid start IP

the docker command has been fixed on tag 0.7.2, but this tag is not supporting k8s prior to 1.26 network=$(docker network inspect kind | jq -r '.[0].IPAM.Config[] | select(.Subnet | test("^[0-9]+\.")) | .Subnet' | cut -d '.' -f1,2)

We woud like to have a tag version that have the fix and supporting at least 1.26

Can we have tag version 0.6.18, with the fix ?

Version

haydentherapper commented 2 months ago

https://github.com/sigstore/scaffolding/releases/tag/v0.7.2 contains an updated metalib.

haydentherapper commented 2 months ago

Sorry, reread the issue. @cpanato could you take a look at backporting the fix?

jkhelil commented 2 months ago

thanks @haydentherapper , we need to backport it

jkhelil commented 2 months ago

@cpanato Would you have a look to this please (backport the fix for setup_kind). thank you

cpanato commented 2 months ago

backport to which version? we will do a release branch? is it not easier to move forward?

jkhelil commented 2 months ago

@cpanato We would need a backport supporting 1.26 and prior to 1.26, backport to 0.6.17 would be very helpful, thank you

cpanato commented 2 months ago

Are we sure we want that? k8s 1.26 is deprecated. I would not prefer to create a release branch to support a deprecated k8s version.

@haydentherapper can we chat about this? ping me over slack

jkhelil commented 2 months ago

@cpanato I think your comment makes sens. We are going to move forward. I will close the issue