rekor-createsecrets image is overwritten by tuf-createsercrets

sigstore / scaffolding

Stuff to make standing up sigstore (esp. for testing) easier for e2e/integration testing.

Apache License 2.0

59 stars 57 forks source link

rekor-createsecrets image is overwritten by tuf-createsercrets #1192

Closed vipulagarwal closed 3 months ago

vipulagarwal commented 4 months ago

Description

rekor-createsecrets image is overwritten by tuf-createsecrets image because they have the same file name. The packages have only one createsecrets image.

ko builds the image based on the go application file name, in this case createsecrets

Version

main

bobcallaway commented 3 months ago

The options here aren't wonderful:

rename rekor/createsecret to rekor-createsecret and tuf/createsecret to tuf-createsecret
insert an explicit image copy somewhere in the Makefile to preserve the images
create and reference a symlink (which has portability challenges)
change ko arguments to change name of all published images

I'm leaning towards the first option, but it definitely feels hackish.

vipulagarwal commented 3 months ago

rename rekor/createsecret to rekor-createsecret and tuf/createsecret to tuf-createsecret

I would keep the original tuf/createsecrets -> createsecrets as it is used in scaffolding and tuf helm charts. We can simply create rekor-createsecrets as this is not used anywhere yet (the image does not exist).

bobcallaway commented 3 months ago

rename rekor/createsecret to rekor-createsecret and tuf/createsecret to tuf-createsecret

I would keep the original tuf/createsecrets -> createsecrets as it is used in scaffolding and tuf helm charts. We can simply create rekor-createsecrets as this is not used anywhere yet (the image does not exist).

sg!