sigstore / scaffolding

Stuff to make standing up sigstore (esp. for testing) easier for e2e/integration testing.
Apache License 2.0
59 stars 57 forks source link

Add different run modes for the TUF server, allow saving TUF keys as a secret #1214

Closed bkabrda closed 3 months ago

bkabrda commented 3 months ago

Summary

Addresses part of https://github.com/sigstore/scaffolding/issues/1182.

This commit implements features necessary to run/operate the TUF server in production much better:

Some notes:

Release Note

Documentation

It feels like this change would deserve some docs, but I don't know if there even are docs for the TUF server. I can certainly write something up if you can point me to the right place.

bkabrda commented 3 months ago

@evankanderson thanks a lot for your review! I think I addressed all the points. As noted in one of the inline comments, the currently saved secret intentionally explicitly excludes the keys directory from being saved. I'm not sure why it was coded this way, but I think it makes sense that these two are independent and the keys secret can be downloaded and deleted altogether. (I don't think this is a huge benefit, but it felt to me that it might be nice, YMMV of course).