Closed bkabrda closed 3 months ago
@evankanderson thanks a lot for your review! I think I addressed all the points. As noted in one of the inline comments, the currently saved secret intentionally explicitly excludes the keys directory from being saved. I'm not sure why it was coded this way, but I think it makes sense that these two are independent and the keys secret can be downloaded and deleted altogether. (I don't think this is a huge benefit, but it felt to me that it might be nice, YMMV of course).
Summary
Addresses part of https://github.com/sigstore/scaffolding/issues/1182.
This commit implements features necessary to run/operate the TUF server in production much better:
init
- only init the TUF repository and exitinit-no-overwrite
- same asinit
, but won't overwrite the TUF repository if it already existsserve
- only serve an existing TUF repository (noinit
)init-and-serve
-init
and thenserve
(this is default to preserve backwards compatibility)/tmp
directory.Some notes:
init
orinit-no-overwrite
to create the TUF repository at a mounted volume.serve
to serve the TUF repository from the mounted volume.Release Note
init
- only init the TUF repository and exitinit-no-overwrite
- same asinit
, but won't overwrite the TUF repository if it already existsserve
- only serve an existing TUF repository (noinit
)init-and-serve
-init
and thenserve
(this is default to preserve backwards compatibility)/tmp
directory.Documentation
It feels like this change would deserve some docs, but I don't know if there even are docs for the TUF server. I can certainly write something up if you can point me to the right place.