Closed haydentherapper closed 4 weeks ago
Additionally, we should either add unit tests for https://github.com/sigstore/sigstore-go/blob/main/pkg/tlog/entry.go or confirm that the unit/integration tests for https://github.com/sigstore/sigstore-go/blob/main/pkg/verify/tlog.go cover entry.go
@vishal-chdhry are you still interested in taking this up or should someone else have a go?
@cmurphy sure I can take this up, I forgot about it
\assign
Description
The mock Sigstore data generates a Rekor log entry with a SignedEntryTimestamp but no inclusion proof (See
generateTlogEntry
).Additionally, we don't test the online verification path since we don't have a fake Rekor client. Should be straightforward to add with something like https://github.com/sigstore/rekor-monitor/blob/main/pkg/rekor/mock/mock_rekor_client.go