search

sigstore / sigstore-java

java clients for sigstore
Apache License 2.0
36 stars 20 forks source link

Another try to fix CHANGELOG.md link in release notes #710

Closed szpak closed 1 month ago

szpak commented 2 months ago

Summary

Another try to fix CHANGELOG.md link in release notes - see https://github.com/sigstore/sigstore-java/pull/706#issuecomment-2125502914

loosebazooka commented 2 months ago

oh need to amend your commit with -s

szpak commented 2 months ago

oh need to amend your commit with -s

Sure, no problem. Btw, it's already signed, but maybe this repo requires to have it signed by the maintainer. The "signed-off-by" was missing.

szpak commented 2 months ago

Ok, I've fixed it by adding "signed-off-by" (the commit was signed).

loosebazooka commented 1 month ago

oh you need to rebase, because I messed something up earlier.

szpak commented 1 month ago

Done

loosebazooka commented 1 month ago

oh right this test can't pass because there is no oidc token... because it's a pull request

szpak commented 1 month ago

Seems to work :) https://github.com/sigstore/sigstore-java/releases/tag/v0.10.0

(let's skip that there are no changes mentioned ;) ).

loosebazooka commented 1 month ago

Will bring doing that after 1.0