search

sigstore / sigstore-java

java clients for sigstore
Apache License 2.0
35 stars 20 forks source link

Avoid rebuilding sigstore/protobuf-specs every time #733

Open vlsi opened 1 month ago

vlsi commented 1 month ago

Currently, sigstore-java rebuilds sigstore/protobuf-specs every time which seems wasteful, and it makes imports like import dev.sigstore.proto. invalid on the first project import.

We should use implementation("dev.sigstore:protobuf-specs:0.3.2") rather than protobuf("dev.sigstore:protobuf-specs:0.3.2")

https://github.com/sigstore/protobuf-specs/issues/341 is needed to fix this

See also:

loosebazooka commented 1 month ago

I actually explicitly didn't do this because of compatibility issues. I wanted to build the protos here