search

sigstore / sigstore-java

java clients for sigstore
Apache License 2.0
45 stars 21 forks source link

only run errorpone in java 17+ #837

Open loosebazooka opened 1 month ago

loosebazooka commented 1 month ago

might be strange for devs working with java11, but our CI will catch it anyway

vlsi commented 1 month ago

I thought we use toolchains for the build, so the build should always use Java 17 no matter which Java is the default. Isn't it the case?

vlsi commented 1 month ago

Ah, we don't have toolchains in sigstore-java yet.

loosebazooka commented 1 month ago

We also want to keep java11 compat, we have all our tests run in Java 11 as well on CI.

vlsi commented 1 month ago

We'd better use Java 17 for the build, and use --release 11 to target Java 11 bytecode/classlib. Then we could use whatever version for executing the tests.

Using Java 17 for the build would avoid us running into javac11 bugs, and it would make all the devs produce pretty-much the same bytecode.