search

sigstore / sigstore-js

Code-signing for npm packages
Apache License 2.0
156 stars 23 forks source link

coverage fixup for node 22 #1289

Closed bdehamer closed 1 month ago

bdehamer commented 1 month ago

Summary

When running the unit tests under node 22, we saw the code coverage stats drop on a number of packages. It appears that the coverage metrics for the ?? and ?. operators are handled differently under node 22.

This PR brings our cover stats back to 100% under node 22. Where possible, I've added new tests to hit the missing code paths -- otherwise, I've excluded specific lines from the coverage metric.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 94e1891ffaafe4be3eec59a46106092555b7f1db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR