search

sigstore / sigstore-python

A Sigstore client written in Python
https://pypi.org/p/sigstore
Other
232 stars 49 forks source link

Fix warning for CLI verification of legacy bundles #1198

Closed facutuesca closed 3 weeks ago

facutuesca commented 3 weeks ago

This PR fixes a check in the CLI command sigstore verify where we should have printed a warning while verifying a legacy bundle (*.sigstore) if no bare materials (*.crt and *.sig) are provided.

The warning was never printed, due to an error in the check that made it always return False.

This PR also adds a regression test for the bug fixed in https://github.com/sigstore/sigstore-python/pull/1192, checking that the CLI correctly verifies a legacy bundle and that it logs the expected warning.

This closes https://github.com/sigstore/sigstore-python/issues/1194.

cc @woodruffw

facutuesca commented 3 weeks ago

Nice work @facutuesca! Mind adding a CHANGELOG entry, since this fixes my broken fix?

Done!

woodruffw commented 3 weeks ago

/gcbrun