Set user-agent in all HTTP requests

sigstore / sigstore-python

A Sigstore client written in Python

https://pypi.org/p/sigstore

Other

227 stars 49 forks source link

Set user-agent in all HTTP requests #985

Closed jku closed 5 months ago

jku commented 6 months ago

Description

It would be useful if sigstore-python had a user-agent in all requests:

[x] fulcio client (#1008)
[x] rekor client (#1008)
[x] tuf client (https://github.com/sigstore/sigstore-python/pull/1017)
[x] oidc (#1008)

Current user-agent is python-requests/2.31.0. I think sigstore-python/X.Y.Z python-requests/2.31.0 (or just sigstore-python/X.Y.Z) would make sense.

This can be implemented one client at a time.

woodruffw commented 6 months ago

Great idea!

woodruffw commented 5 months ago

Completed as of https://github.com/sigstore/sigstore-python/pull/1017, I believe 🙂