search

sigstore / sigstore-rs

An experimental Rust crate for sigstore
https://sigstore.github.io/sigstore-rs/sigstore/
Apache License 2.0
164 stars 51 forks source link

update tough dep #340

Closed astoycos closed 6 months ago

astoycos commented 6 months ago

Summary

DO NOT MERGE UNTIL https://github.com/awslabs/tough/pull/755 merges and the fixed crate to @kommendorkapten is updated

https://github.com/awslabs/tough/pull/755 merged but still isn't in a released version

Rebases and updates https://github.com/sigstore/sigstore-rs/pull/320

This commit updates the tough dependency, which changes how many of our trait definitions work.

Additionally move from the use of oncecell to oncelock for sigstoretrustroot.trusted_root so that SigstoreTrustRoot can be Send.

Update examples and tests.

Manual fix for https://github.com/sigstore/sigstore-rs/pull/317 and https://github.com/sigstore/sigstore-rs/pull/337

Fixes #338

Release Note

Documentation

astoycos commented 6 months ago

Once https://github.com/awslabs/tough/pull/759 Merges I'll be able to use the tagged release version of tough here 🥳

astoycos commented 6 months ago

cc @Xynnn007 and @kommendorkapten for reviews

astoycos commented 6 months ago

Touch point we're using this downstream in https://github.com/bpfman/bpfman/pull/1042

haydentherapper commented 6 months ago

also cc @flavio

flavio commented 6 months ago

@astoycos thanks a lot for having created this PR. I left some comments, please make sure all the tests are passing

flavio commented 6 months ago

Great news, a new tough release is out: https://github.com/awslabs/tough/releases/tag/tough-v0.17.1

astoycos commented 6 months ago

Thanks for the reviews @flavio!

flavio commented 6 months ago

I'm waiting for all the tests to be green, then I'll merge it :)