search

sigstore / sigstore-rs

An experimental Rust crate for sigstore
https://sigstore.github.io/sigstore-rs/sigstore/
Apache License 2.0
164 stars 51 forks source link

RUSTSEC-2023-0055: Multiple soundness issues #367

Open github-actions[bot] opened 4 months ago

github-actions[bot] commented 4 months ago

Multiple soundness issues

Details
Status unsound
Package lexical
Version 6.1.1
URL []()
Date 2023-09-03

lexical contains multiple soundness issues:

  1. Bytes::read() allows creating instances of types with invalid bit patterns
  2. BytesIter::read() advances iterators out of bounds
  3. The BytesIter trait has safety invariants but is public and not marked unsafe
  4. write_float() calls MaybeUninit::assume_init() on uninitialized data, which is is not allowed by the Rust abstract machine

The crate also has some correctness issues and appears to be unmaintained.

Alternatives

For quickly parsing floating-point numbers third-party crates are no longer needed. A fast float parsing algorith by the author of lexical has been merged into libcore.

For quickly parsing integers, consider atoi and btoi crates (100% safe code). atoi_radix10 provides even faster parsing, but only with -C target-cpu=native, and at the cost of some unsafe.

For formatting integers in a #[no_std] context consider the numtoa crate.

For working with big numbers consider num-bigint and num-traits.

See advisory page for additional details.

tannaurus commented 2 weeks ago

This appears to have silenced in main https://github.com/sigstore/sigstore-rs/pull/387/files

This that a temporary solution, do we plan on monitoring this further?

A new warning has taken its place: https://rustsec.org/advisories/RUSTSEC-2023-0086

flavio commented 1 week ago

I've created https://github.com/timothee-haudebourg/json-number/pull/6 that addresses both issues.