search

sigstore / timestamp-authority

RFC3161 Timestamp Authority
Apache License 2.0
67 stars 38 forks source link

Fixes #846 #847

Closed DarkaMaul closed 1 month ago

DarkaMaul commented 1 month ago

Summary

This PR fixes the problem highlighted in #846 .

Release Note

FIX TimestampResponse Time were not properly returned as GMT.

Documentation

None

haydentherapper commented 1 month ago

Would you be able to confirm that the timestamp client here properly handles timezones/UTC? I would assume yes since we're just using the standard library.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 45.92%. Comparing base (6fd19b0) to head (157a5ac). Report is 194 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #847 +/- ## ========================================== - Coverage 52.85% 45.92% -6.94% ========================================== Files 20 55 +35 Lines 1209 2942 +1733 ========================================== + Hits 639 1351 +712 - Misses 509 1451 +942 - Partials 61 140 +79 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DarkaMaul commented 1 month ago

Would you be able to confirm that the timestamp client here properly handles timezones/UTC? I would assume yes since we're just using the standard library.

Yes - confirmed this this morning.

haydentherapper commented 1 month ago

Thank you!