search

sii / siptrackd

Other
0 stars 4 forks source link

Getting 'No module named MySQLdb' while using sqlite3 #9

Closed nesanton closed 6 years ago

nesanton commented 6 years ago

Hi, It seems that both storage engines are imported unconditionally here. Should they be? https://github.com/sii/siptrackd/blob/4dc71d18eb617e8d0f3b2a07fd230e0cfb10b955/siptrackdlib/storage/__init__.py#L2

I'm using sqlite only Commenting out stmysql import made it work

stemid commented 6 years ago

I assume you're getting import errors when you run siptrackd?

Yes they're both imported but that shouldn't be an issue unless you're missing the mysql client library in your install.

It's really just a matter of installing the "mariadb-devel mariadb" packages for your distro, and complementing with the MySQL-python package which is already in requirements.txt for siptrackd.

So it should be enough to follow the install instructions.

But yeah they're imported unconditionally and that might not be optimal but it's very low priority to change so unless you submit a PR it probably won't get changed until after all the other enhancements.

nesanton commented 6 years ago

Yes, indeed while running siptrackd.

surely requirements.txt always worked and it's good enough. It's just this one system with compiled python. Still no problem, just extra steps

Thanks! closing