sijad / flarum-ext-links

https://github.com/FriendsOfFlarum/links
MIT License
23 stars 9 forks source link

Add an option to open links in newtab #1

Closed sijad closed 8 years ago

Alir3z4 commented 8 years ago

Normally when creating link from admin area, being able to pass the value of html tag target would be enough.

sijad commented 8 years ago

as we just need add _blank as target attribute, I was thinking about adding a check box to that form

Alir3z4 commented 8 years ago

Forgive me for my abstract/generic thinking, I'm more of a backend developer and my frontend knowledge is not that detail covered.

Having a checkbox makes more sense of course. Hope to see this feature implemented soon.

sijad commented 8 years ago

fixed in https://github.com/sijad/flarum-ext-links/commit/6c84357d2d5dae25bb482ddd3b0bd6436ea39b0e