Closed ivdma closed 8 years ago
sijbrandij
commented
10 years ago Hey, when I was reviewing this pull request rbenv started complaining that it had version 2.1.0 not installed. Any idea where that is coming from?
I reviewed the pull request, everything seems fine. Before I merge, I want to know where this 2.1.0 came from, because I think it may be too recent to run our production environment on.
ivdma
commented
10 years ago Hi Karen,
It comes from https://github.com/imalijkh/railsgirls-nl/blob/gimme-some-specs/.ruby-version This file shouldn't be under version control. You can just add .ruby-version line to .gitignore file and commit .gitignore.
On Fri, Apr 4, 2014 at 11:27 AM, sijbrandij notifications@github.comwrote:
Hey, when I was reviewing this pull request rbenv started complaining that it had version 2.1.0 not installed. Any idea where that is coming from?
I reviewed the pull request, everything seems fine. Before I merge, I want to know where this 2.1.0 came from, because I think it may be too recent to run our production environment on.
Reply to this email directly or view it on GitHubhttps://github.com/sijbrandij/railsgirls-nl/pull/56#issuecomment-39546601 .
Willianvdv
commented
10 years ago @sijbrandij before this pr the ruby version was defined in the Gemfile (https://github.com/sijbrandij/railsgirls-nl/pull/56/files#diff-8b7db4d5cc4b8f6dc8feb7030baa2478L2).
sijbrandij
commented
10 years ago I know. Heroku likes it that way ;) Op 4 apr. 2014 12:19 schreef "Willian van der Velde" < notifications@github.com>:
@sijbrandij https://github.com/sijbrandij before this pr the ruby version was defined in the Gemfile ( https://github.com/imalijkh/railsgirls-nl/blob/e08ee92518eac542a2c157bfbcd9820a158ca975/Gemfile#L2 ).
Reply to this email directly or view it on GitHubhttps://github.com/sijbrandij/railsgirls-nl/pull/56#issuecomment-39550552 .
ALL YOUR TESTS ARE BELONGS TO US