search

sijms / go-ora

Pure go oracle client
MIT License
786 stars 174 forks source link

Augment bad connection management #456

Closed DrHayt closed 10 months ago

DrHayt commented 10 months ago

Fixes #455

This set of changes primarily does 3 things:

  1. Changes the "bad" connection indicator to be something that can be atomically managed.
  2. Sets the connection to be "bad" in every place that isBadConn(err) says that the connection is bad.
  3. Augments the OracleError type to have a Bad() method so that oracle error codes indicating that the connection is invalid are stored in one place.
DrHayt commented 10 months ago

@sijms How does this look? Do you need anything in order to evaluate effectiveness, tests, or anything?

sijms commented 10 months ago

sorry for late replay. I stuck in some work yes it is ok thank you for your help