Maintenance: Small Enhancements and Bug Fixes

phauer commented 9 years ago

Hi Gijs,

I like to contribute the following changes:

Added FitNesseVersion 20150226 and the cutting edge 20150424 to the list of supported versions. In our project we used both in conjunction with mafia and everything works fine.
There are cases where the test result xml doesn't contain an node (e.g. if there are no decision tables in a fitnesse test). This case is taken into account now.
I removed the unpackWaitTime configuration, because it is no longer used.
Instead I introduced the configuration connectionAttempts. This defines how often Mafia will try to connect to FitNesse (to determine if the startup has finished) before giving up.
Improved writeSurefireReports functionality: If a test execution fails (e.g. with a "Read timed out" which happens often with 20150226, but was fixed in 20150424), a surefire report is created signaling this error. Otherwise Jenkins thinks everything worked out fine.

I guess we are close to a release. Just give me some more days be sure, that everything works fine and stable. I will contact you, when I consider my enhancements to be good enough for a release. Are you OK about this approach? :-)

Best Regards, Philipp

phauer commented 9 years ago

Hi Gijs, Since a couple of weeks we are working with the new features I introduced in the mafia plugin and everything works fine. I guess we can now release the new features - after you have merged this pull request. :-)

Regards, Philipp

sijpesteijn commented 9 years ago

I'm trying to release the plugin, but something changed on sonatype.org. I'm trying to figure out what needs to be done now. Bare with me.

sijpesteijn commented 9 years ago

Ok, 2.1.6 is released: http://search.maven.org/#artifactdetails%7Cnl.sijpesteijn.testing.fitnesse.plugins%7Cmafia-maven-plugin%7C2.1.6%7Cmaven-plugin

phauer commented 9 years ago

Thank you very much!

sijpesteijn / mafia-maven-plugin

Maintenance: Small Enhancements and Bug Fixes #22