sikai00 / pe

0 stars 0 forks source link

Any edits to the person, including remark, causes the detailed information to disappear #3

Open sikai00 opened 1 year ago

sikai00 commented 1 year ago

This is unlikely to be the behavior we want as we want to be able to see the changes made. For example, remark, attendance or edit causes the person's detailed information that we are currently viewing to disappear. This effect is not limited to edit as reported in a previous issue, but also in remark.

image.png

soc-pe-bot commented 1 year ago

Team's Response

We designed TAB such that users need to click on the updated contact in order to view the updated details so that users can continue moving forward to updating other contacts, thus we feel that the severity should be low.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: > "We designed TAB such that users need to click on the updated contact in order to view the updated details so that users can continue moving forward to updating other contacts, thus we feel that the severity should be low."

The reasoning seems to be invalid: 1) Why was there an active design consideration made to prevent a user from directly seeing their updates and edits? It is more than likely a user wants to see their changes being reflected.

2) Having to force a user to click already violates the constraint of CLI-First.

3) This does not seem like an intention. Rather, it is a bug stemming from the immutability of a Person object, and the view panel is not being actively updated with the new immutable object created to take the old's place. The old one disappears also because it was deleted.

This severity is valid as it affects most users to a large extent, and poses an inconvenience everytime a user wants to update attendance or assignment scores etc.