sikai00 / pe

0 stars 0 forks source link

Decimals in percentage for assignment weightage is not allowed #5

Open sikai00 opened 1 year ago

sikai00 commented 1 year ago

image.png

This restricts the users ability to create more well defined weightages, perhaps 0.5% might be used for participation.

nus-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Assignment Weightage Bug

Bug Report:

What Happened:

  • Assignment weightages need to be in whole numbers without being explicitly stated.
  • It is also not too far-fetched for assignment weightages to be decimals.

Steps to reproduce:

  1. assignments assignments/ ASSIGNMENT_1 w/12.5 , ASSIGNMENT_2 w/87.5

Screenshots

Screenshot 2022-11-11 at 5.09.10 PM.pngScreenshot 2022-11-11 at 5.09.10 PM


[original: nus-cs2103-AY2223S1/pe-interim#572] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We accept that this should be better written in the error message. However, we have this described in our UG. Therefore we believe that this is unlikely to affect normal operations for a normal user that has read our UG before use. Therefore rectifying this will be less important. Therefore this will be classified NotInScope

Screenshot 2022-11-14 at 2.42.06 AM.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: This appears to be an issue caused by overzealous checking, i.e., only a check for the total to be 100% was needed, but the team went ahead and decided to disallow non-integers. Given its simplicity to fix, I believe this is in scope. It is also reasonable to allow decimal points for the app to be reasonably useful to users.

image.png