search

sikanhe / gqtx

Code-first Typescript GraphQL Server without codegen or metaprogramming
458 stars 13 forks source link

feat: introduce esm and cjs support #42

Closed n1ru4l closed 3 years ago

n1ru4l commented 3 years ago

I am following this comment:

https://github.com/d3/d3/issues/3469#issue-809713670

This should close https://github.com/sikanhe/gqtx/issues/3 (and also https://github.com/sikanhe/gqtx/pull/42)

See https://unpkg.com/browse/gqtx@0.8.1-a9325d31.0/ for a folder structure overview of the published package. See https://unpkg.com/browse/gqtx@0.8.1-913ef0b2.0/ for a file directory overview.

sikanhe commented 3 years ago

LGTM

n1ru4l commented 3 years ago

Please not merge yet I still need to confirm out whether it works correctly with the most common use-cases

sikanhe commented 3 years ago

@n1ru4l feel free to merge when you have it working!

n1ru4l commented 3 years ago

Ok, it seems to work. It is a bit ugly though and all the files had to be moved to the package root... But it seems like its the only way to properly support both ESM and typescript in a backwards-compatible way until typescript introduces proper ESM support...

See https://unpkg.com/browse/gqtx@0.8.1-913ef0b2.0/ for a file directory overview.

Gonna leave this open for a few days if anyone has some more feedback. Otherwise, I will merge it probably some day on the weekend. Maybe @zth has something to add?