Events overhaul & various fixes

sikanhe / reason-nodejs

Node bindings for Reason and Bucklescript

MIT License

100 stars 18 forks source link

Closed austindd closed 4 years ago

austindd commented 4 years ago

This branch got a little bit out of scope, but here are the main things:

make all event handler types uncurried.
implement the off, once, and removeAllListeners functions for subclasses of EventEmitter.
fixes to some of the Stream subtypes.
minor changes to Stream subtype polyvariant types.
minor fixes in random places.
in the FS module, all functions that read/write string types are removed, along with the encoding parameters that coerce the function types.

sikanhe commented 4 years ago

Can we check compiled output just in case to spot anything abnormal

austindd commented 4 years ago

@sikanhe we can definitely check the output. Any parts in particular that you're concerned about?